jyr0s · HackerTrans

vor 5 Jahrendiscuss

aren't Ethernet frames CRC'd? Are there other checksums down the call stack, or up the stack at the other end, that would reject such bit flips in the raw data?

jyr0s

vor 6 Jahrendiscuss

There's a dead comment that seems pretty revealing in terms of the review process:

    SmallPeePeeMan 13 hours ago [dead] [–]

    I’m an extension reviewer at adding.mozilla.org. Extensions that request certain permissions are manually reviewed. Others are automatically approved. Recommend extensions are ALWAYS manually reviewed for each update.

I'm curious what the _manual review_ process looks like. There are so many questions that come to mind: Is it a single person or multiple individuals reviewing the extension? Does it require the reviewer to be familiar with the code base of the extension? Wouldn't that be a significant burden, or are these reviews cursory? Do the reviews take 10 minutes? 30 minutes? days? Is the review documented? Can the review be public? Do they review the source code on github/gitlab/etc or are they reviewing the submitted file(s)?

jyr0s

vor 6 Jahrendiscuss

Are you proposing to do that for every update that comes in, for every extension? Far from ideal.

jyr0s

vor 6 Jahrendiscuss

A few of these have the "Access your data for all websites" permission and honestly, I can't shake the feeling that I'm giving away all data on all websites at all times if I install any of these

jyr0s

vor 8 Jahrendiscuss

See master branch: https://github.com/shadowsocks/shadowsocks/tree/master

comments