HackerTrans
TopNewTrendsCommentsPastAskShowJobs

compacct27

no profile record

comments

compacct27
·hace 4 meses·discuss
This isn't it. After spending my morning on a code review and catching several major issues despite it being a +7kloc diff, the real question is--how do we make the tooling around code reviews better? Intentions aren't enough, they're vague and the implementation details matter. They help, though, and this is closer to the answer to code reviews: check out the intentions, get an AI-assisted overview of the architecture of the code, then dive into the more important parts of the architecture.

Maybe it's because I'm in UI dev, but intentions aren't enough at all
compacct27
·hace 9 meses·discuss
They have web components if you want
compacct27
·hace 9 meses·discuss
“Build our platform for us!”
compacct27
·hace 10 meses·discuss
Or less!
compacct27
·hace 10 meses·discuss
Integrating these web components into our React codebase has been pretty awful--more of a web components thing than a Lit thing, IMO. We have "scoped styles", except for certain important things like font sizes, so tons of little regressions everywhere when we swap in the web component in place of the old React one. DX-wise, we lost a lot, too. I assume the tooling will get better, or that we'll figure it out more, but it's mostly been a drag