> Now, most people spend a majority of their time in a locked down environment (phones and tablets) consuming locked down content (subscription only, on approved devices). The default 15 years ago was open, now it is default closed.
I love having the choice. Most of the time I want the locked-down thing. A bunch of extra "freedom" I'm not actually using is just a hassle and liability when all I wanna do is take and crop some photos, or do some writing, or whatever.
Now we have that option, and then also general-purpose computers are so cheap and widely available that you can easily score decent ones for free.
Far from being some computing apocalypse, the situation now is excellent. Computers were a barely-tolerated near-failure for most normal use cases, but now there are options that don't suck for normal people wanting to do normal things. And general-purpose computing is more accessible than ever.
Maybe some Dark Age of Computing still lurks, but it's not happened yet, and things have only gotten better so far.
IMO the worst thing about the current computing era are the handful of Web monopolies and the way "AI"/machine-learning has mostly enabled systems working against us rather than creating agents working entirely on our behalf.
> * Should we extract this to a separate function?
Reads very passive aggressive. No.
> * Could you extract this to a separate function?
Yes, I could.
> * I would extract this to a separate function.
Good for you.
> * This could be extracted to a separate function.
This one's OK as a style suggestion that you won't block the merge over.
> * This should be extracted to a separate function.
This is kinda, sorta OK, if you're going to block the merge if this isn't fixed.
> * Extract this to a separate function.
This is better because the tone matches the intent: it's a command. This gets addressed, or no merge. "This should..." is indirect—you're not stating what you actually mean. This phrasing is better.
4 is the best of these for optional suggestions, 6 is best if you consider the fix a requirement for a merge. In general, say what you actually mean—dancing around it leaves room for miscommunication and can give all kinds of bad impressions. Of course, that can also mean weakening language: don't command a change that you don't consider a big enough deal to block the merge.
[EDIT] And, as others have noted in the thread, of course expanding with justifications is always a good idea. "Do this" without a "why" should be avoided. But lead with what you want done, not the why—that follows.
I love having the choice. Most of the time I want the locked-down thing. A bunch of extra "freedom" I'm not actually using is just a hassle and liability when all I wanna do is take and crop some photos, or do some writing, or whatever.
Now we have that option, and then also general-purpose computers are so cheap and widely available that you can easily score decent ones for free.
Far from being some computing apocalypse, the situation now is excellent. Computers were a barely-tolerated near-failure for most normal use cases, but now there are options that don't suck for normal people wanting to do normal things. And general-purpose computing is more accessible than ever.
Maybe some Dark Age of Computing still lurks, but it's not happened yet, and things have only gotten better so far.
IMO the worst thing about the current computing era are the handful of Web monopolies and the way "AI"/machine-learning has mostly enabled systems working against us rather than creating agents working entirely on our behalf.