“Instead of doing A here, let us instead use a B approach, otherwise there is a risk of C happening.”
And for shit: “This isn’t great because X. A refactor needs to take Y into consideration, which will result in Z-quality code.”
It’s all case by case, though, in reality. If I know someone we’ll, I might ask why they went with a certain style or a particular algorithm and just talk them through to grokking the error. If they’re somebody who is newer to the field, I usually point them towards a linter, especially if what I’m reviewing would’ve been flagged by said linter.
“Instead of doing A here, let us instead use a B approach, otherwise there is a risk of C happening.”
And for shit: “This isn’t great because X. A refactor needs to take Y into consideration, which will result in Z-quality code.”
It’s all case by case, though, in reality. If I know someone we’ll, I might ask why they went with a certain style or a particular algorithm and just talk them through to grokking the error. If they’re somebody who is newer to the field, I usually point them towards a linter, especially if what I’m reviewing would’ve been flagged by said linter.