Show HN: Zerobox – a small lightbox(github.com)
github.com
Show HN: Zerobox – a small lightbox
https://github.com/kolodny/zerobox
20 comments
Nice, nice. Simple, light.
Just wondering what the license is. As it is (No license), standard copyright applies. I'd rather see something like BSD or GPL.
Here's what I started using recently (MIT): http://dimsemenov.com/plugins/magnific-popup/
MIT, forgot to put that in there
Make it work with zepto instead of jquery, and move most of it into a CSS file, and you'll be golden :)
Your lightbox is fine on my iPhone, but can anyone tell me what's going on with the DEMO link on the Github page? I can't get it to open with a tap from either Safari or Chrome on my iPhone. Do you think Modernizr is doing something weird with that hyperlink on mobile?
Pretty cool, but is there any need to use jQuery?
You could have achieved the same with vanilla JS and CSS transitions
You could have achieved the same with vanilla JS and CSS transitions
this has been debated endlessly, the use of jQuery is not an issue. An abstraction layer like jQuery buffers the code from browser differences and since it's almost always already in the user's cache and nearly always used for anything non trivial, it's overhead is minimal both from a networking point of view and code path.
Well, I have actually been going through many lightbox clones lately and almost all have a dependency on jQuery. The problem lies in when you are trying to inject a lightbox into a page you are not the creator of and they are using a very old outdated jQuery, causing conflicts. (When used for making browser extensions etc). This would be perfect for me if it was not dependent on jQuery and loaded iFrames and inline html (other options out there are bloated and outdated), but regardless, awesome job and thank you for the contribution :)
Looks good! It's small, simple, and does exactly that it should.
I was happy to see that the use of jQuery animations worked fine on my iPhone as well (I was expecting it to be choppy due to the lack of CSS animations).
Awesome work!
I was happy to see that the use of jQuery animations worked fine on my iPhone as well (I was expecting it to be choppy due to the lack of CSS animations).
Awesome work!
worked on my android device as well. neat!
This might make sense to be added to Bootstrap.
Using my ipad, nothing happens when i click on "demo".
Chrome on my iPad, the demo button doesn't do anything. When I long press and 'Open in new Tab' the demo page opens.
Tabs for indentation and not spaces =/
Maybe he just wanted to follow jQuery convention for a jQuery plugin?
http://contribute.jquery.org/style-guide/js/
> Indentation with tabs.
http://contribute.jquery.org/style-guide/js/
> Indentation with tabs.
You can have my hard tabs when you pry them from my cold, dead, RSI-crippled hands.
:)
Thanks for the highly substantive feedback and raising the level of discourse on HN.