Looking Back on Phabricator for Code Review(davidgomes.com)
davidgomes.com
Looking Back on Phabricator for Code Review
https://davidgomes.com/phabricator-code-review/
3 comments
I loved Phabricator and hadn't heard about Phorge. Co-signed on all of these points.
> In GitHub, you have to switch tabs (which is slow and distracting) to go between the PR summary and the code.
As a case study of Github UI friction, take merging a Dependabot PR from the PRs tab, with code approval required before merges. By my count this takes 6 clicks, and none of them approach a 'snappy' response time.
This is for mostly trivial single-line diffs. The entire thing could be 1 click - a hover preview on the PR list, and an 'approve and merge' button.
(To list them out: Click PR, "Files changed", "Submit review", "Approve", "Submit Review", "Merge")
As a case study of Github UI friction, take merging a Dependabot PR from the PRs tab, with code approval required before merges. By my count this takes 6 clicks, and none of them approach a 'snappy' response time.
This is for mostly trivial single-line diffs. The entire thing could be 1 click - a hover preview on the PR list, and an 'approve and merge' button.
(To list them out: Click PR, "Files changed", "Submit review", "Approve", "Submit Review", "Merge")
Does Facebook/Meta still use Phabricator or Phorge directly? Or do they use a fork of one of them internally?