Show HN: A Go package to execute shell commands in specified order(github.com)

3 pointsby amalfra9 ปีที่แล้ว3 comments

Show HN: A Go package to execute shell commands in specified order

https://github.com/amalfra/oexec

3 comments

noasiwiwiwu9 ปีที่แล้ว

Hi

Your software is broken by assuming a command can be split up into arguments by spaces, and also not letting the os package properly escape your arguments.

https://github.com/amalfra/oexec/blob/master/oexec.go#L48

Here's a command that would be impossible to execute with your software, notice how the last argument is a single argument:

    c := exec.Command(
        "/usr/bin/osascript",
        "-e",
        "say 5")
    output, err := c.CombinedOutput()

amalfra9 ปีที่แล้ว

Thanks for pointing it out. Won't quoting the command in the package's function call itself work, for eg:

outs := oexec.Series("/usr/bin/osascript -e 'say 5'")

I think even when running command in shell prompt arguments with space are supposed to be escaped with quotes

sigmonsays9 ปีที่แล้ว

Came by to mention the broken design...