Show HN: Haystack Code Reviewer – Perform code reviews on a canvas(haystackeditor.com)
haystackeditor.com
Show HN: Haystack Code Reviewer – Perform code reviews on a canvas
https://haystackeditor.com/code-reviewer
22 comments
Sweet editor, I can already think of a few good use cases to use on a couple projects
This looks interesting - looking forward to see where it heads!
An entirely nitpicky nitpick: The demo GIF rubs me the wrong way. I know, you want to show of all the features quickly, but what I see when I watch it is a reviewer who doesn't actually read the code, just clicks "reviewed" everywhere, and throws in a slightly patronizing "Good job!"
If you have a moment, you might want to think about a flow that's better at demonstrating how it improves code reviews delivered.
But, as I said, nitpick. There's a lot of potential here!
An entirely nitpicky nitpick: The demo GIF rubs me the wrong way. I know, you want to show of all the features quickly, but what I see when I watch it is a reviewer who doesn't actually read the code, just clicks "reviewed" everywhere, and throws in a slightly patronizing "Good job!"
If you have a moment, you might want to think about a flow that's better at demonstrating how it improves code reviews delivered.
But, as I said, nitpick. There's a lot of potential here!
Good point! Yeah I think I should record myself doing an actual review while balancing showing the complete feature set.
Thank you!
Thank you!
I think I understand what it does and it looks interesting and appealing. My team would need Ruby support. Not sure if you'll be able to connect the graph properly in Ruby, but it might still be useful.
We would need ruby support too.
Beyond that, if my MR/PR has two (or more) logical commits, will the tool support reviewing each in isolation? Often times, I will do a refactor in the first commit, and have a second commit with the new feature that makes use of the refactor. Reviewing it all together can result in muddying the water.
Another thought: if I edit a function to call a different function defined elsewhere in my codebase, is there a way to include that functions definition into the canvas (either by the author in preparation for a reviewer, or by the reviewer) to facilitate verifying the behavior across this new boundary?
Beyond that, if my MR/PR has two (or more) logical commits, will the tool support reviewing each in isolation? Often times, I will do a refactor in the first commit, and have a second commit with the new feature that makes use of the refactor. Reviewing it all together can result in muddying the water.
Another thought: if I edit a function to call a different function defined elsewhere in my codebase, is there a way to include that functions definition into the canvas (either by the author in preparation for a reviewer, or by the reviewer) to facilitate verifying the behavior across this new boundary?
Ruby is now supported on Haystack and it should have a graph connected correctly!
We can get it working with Ruby ASAP!
What does it do apart from the call graph? If I had jump-to-definition and find-references in the line-by-line code review UI, what extra benefits would I have by using Haystack?
> If I had jump-to-definition and find-references in the line-by-line code review UI
I think the main benefit of Haystack is that it allows you to keep a model of how the pull request works on the canvas, rather than manually needing to gain an understanding of it in your head.
Even with goto definition/references, I need to understand what parts of the pull request are net new and work together (e.g. I created a new function A that relies on a new class B and calls a new function C) and what parts are linked with existing parts of the codebase.
Normally, this would require me to do some digging around, but with Haystack a lot of this work is done for me in a visual way, allowing me to understand a pull request significantly faster.
I think the main benefit of Haystack is that it allows you to keep a model of how the pull request works on the canvas, rather than manually needing to gain an understanding of it in your head.
Even with goto definition/references, I need to understand what parts of the pull request are net new and work together (e.g. I created a new function A that relies on a new class B and calls a new function C) and what parts are linked with existing parts of the codebase.
Normally, this would require me to do some digging around, but with Haystack a lot of this work is done for me in a visual way, allowing me to understand a pull request significantly faster.
This is promising.
Does it works on local without any login? I review github pull requests in vscode and this seems extention of that workflow where I can visualise the PR
Does it works on local without any login? I review github pull requests in vscode and this seems extention of that workflow where I can visualise the PR
As of now, you need to log in on desktop to review pull requests. Theoretically, we would not require login if your pull requests are in a public repo. If that's the case, I can get a change in for this ASAP!
EDIT: By log in, I mean you have to log in to GitHub. There's no separate Haystack log in.
EDIT: By log in, I mean you have to log in to GitHub. There's no separate Haystack log in.
Looks really great! I'm definitely interested in self hosting
This looks incredible! How does language support work? (I'm curious about Kotlin in particular)
Language support relies on the same language servers that VS Code uses (i.e. language extensions)! Servers come pre-installed with a variety of extensions, but I believe we do not install Kotlin for now. We'll get Kotlin installed (this was just an oversight)!
Maybe this is not for me, but I don't understand what it does
What do those groups and arrows mean?
What do those groups and arrows mean?
If you don't understand what it does the fault is all mine!
The arrows represent dependencies. For example, if you create a function A that calls a function B in a pull request: 1. We'll render function A as a diff on the top part of the canvas 2. We'll render function B as a diff on the bottom part of the canvas And we'll draw an arrow from A to B, to represent that A is calling B
In this way, you can more easily understand the relationships between different parts of what someone is editing. We hope that this reduces the amount of mental modeling or mapping someone has to do during code review!
The arrows represent dependencies. For example, if you create a function A that calls a function B in a pull request: 1. We'll render function A as a diff on the top part of the canvas 2. We'll render function B as a diff on the bottom part of the canvas And we'll draw an arrow from A to B, to represent that A is calling B
In this way, you can more easily understand the relationships between different parts of what someone is editing. We hope that this reduces the amount of mental modeling or mapping someone has to do during code review!
I have always wanted to do something like this! Great work.
Nice job guys!
We’re building Haystack Code Reviewer, a tool that lays out code diffs for a GitHub pull request on an interactive canvas. Instead of scrolling through diffs line-by-line, you can view all changes in a more connected, visual format – similar to viewing a call graph. We hope this will make it easier and less cognitively taxing to understand how different changes across files work together.
For a quick overview, check out our short demo video: https://www.youtube.com/watch?v=QeOz70x0WPE. If you would like to give it a spin, head over to https://haystackeditor.dev, click the “Review pull request button” in the top toolbar, and load any pull request via URL or pick a pull request from a dropdown.
We built Haystack Code Reviewer because we found pull requests difficult to review in a pure textual format — especially when hopping between multiple files or trying to break down complex changes. Oftentimes, pull request authors would have to specifically structure their commits so that code reviews would be easier to tackle, which is a time-consuming and error-prone process. Our goal is to make any pull request easy to understand at a glance, and reduce the effort needed from both reviewers and authors to craft a good code review.
Haystack Code Reviewer works on private repositories! We have authentication to ensure that someone cannot open the server for your pull request without having access to that pull request on GitHub. For additional security, we plan to build self-hosting soon. Please contact us if you’re interested in this.
Alternatively, a completely local option would be to download desktop Haystack and then navigate to your pull request from there. This is great for trying out the feature without exposing any data on the cloud!
In the near future, we plan to:
1. Introduce step-by-step navigation to guide reviewers through each part of the changeset
2. Allow for self-hosting
We’d love to hear your thoughts, suggestions, and any feedback on our approach or potential features!